qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] PATCH: Control over drive open modes for backing file


From: Paul Brook
Subject: Re: [Qemu-devel] PATCH: Control over drive open modes for backing file
Date: Thu, 31 Jul 2008 14:46:55 +0100
User-agent: KMail/1.9.9

> +#define BDRV_O_RDONLY      0x0001 /* Force read-only */
> +#define BDRV_O_WRONLY      0x0002 /* Force writeable, no fallback */
> +#define BDRV_O_RDWR        0x0003 /* Try writeable, fallback to read-only
> */

This is IMHO really misleading.  Normal O_* are not bitflags. The code uses 
these as bitflags sometimes, which means your descriptions are contradictory.

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]