Re: [Qemu-devel] [PATCH 1/7] xen: groundwork for xen support

[Blue Swirl]

On 8/4/08, Gerd Hoffmann <address@hidden> wrote:
>  - allow xenpv machines run without disk and kernel specified
>   by adding a nodisk_ok field to QEMUMachine.

Nice idea, this would be a useful feature by itself.

>  +  $(XEN_OBJS) : CFLAGS += -Wall -Wmissing-prototypes -Wstrict-prototypes

These aren't needed for Xen. Though I wonder why at least -Wall
-Wstrict-prototypes could not be added globally.

>  +    if (-1 != xen_present)

This style looks alien to me. Do you really find it readable?