qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/7] xen: add console backend driver.


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 3/7] xen: add console backend driver.
Date: Mon, 04 Aug 2008 20:15:06 +0200
User-agent: Thunderbird 2.0.0.14 (X11/20080501)

Blue Swirl wrote:
> On 8/4/08, Gerd Hoffmann <address@hidden> wrote:
>>  +       buffer->data = realloc(buffer->data, buffer->capacity);
> 
> On Qemu, instead of malloc,  qemu_malloc should be used to allocate
> memory. Though there isn't qemu_realloc.

Should I add qemu_realloc then?

>>  +    if (!type || 0 != strcmp(type, "ioemu")) {
> 
> Shouldn't this be "qemu"?

No, "ioemu" is correct.  xend writes that value into xenstore.

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]