Re: [Qemu-devel] [patch 1/5][v2] Extract code from get_cluster_offset()

[Laurent Vivier]

Le mardi 05 août 2008 à 16:34 +0200, Kevin Wolf a écrit :
> Laurent Vivier schrieb:
> > It is a cut&paste... so I don't know what it is really doing and I don't
> > want to modify something that has no direct link to the goal I reach...
> > even a variable name.
> 
> I know and I certainly don't want you to include this change in this
> patch as it would make the patch even worse to read. This would be more
> of a change for some [patch 6/5] with the accumulated minor cleanups.

Well, I don't like minor cleanups ;-)

> > I'm currently testing these patches with encrypted disk and compressed
> > disk, and I've found a bug with encrypted one. I'll repost patches soon.
> 
> So the segfault when saving a snapshot with encrypted disks is gone? ;-)

It corrects segfault with encrypted disk... for the moment I don't test
it with snapshot (next step)...

Regards,
Laurent
-- 
----------------- address@hidden  ------------------
  "La perfection est atteinte non quand il ne reste rien à
ajouter mais quand il ne reste rien à enlever." Saint Exupéry