qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [patch 2/5][v2] Divide get_cluster_offset()


From: Laurent Vivier
Subject: Re: [Qemu-devel] [patch 2/5][v2] Divide get_cluster_offset()
Date: Tue, 05 Aug 2008 17:25:10 +0200

Le mardi 05 août 2008 à 17:13 +0200, Kevin Wolf a écrit :
[...]
> Why are you moving that code around? I don't think it's needed for the
> get_cluster_offset/allocate_cluster_offset split. You're just
> duplicating the write and return.

You're right but doing this here allows to clearly split compressed case
and normal case. It is doing for following patches.
 
> Otherwise, the patch looks fine and makes the whole thing much cleaner.

Thank you,
Laurent
-- 
----------------- address@hidden  ------------------
  "La perfection est atteinte non quand il ne reste rien à
ajouter mais quand il ne reste rien à enlever." Saint Exupéry





reply via email to

[Prev in Thread] Current Thread [Next in Thread]