Re: [Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu

[Markus Armbruster]

Samuel Thibault <address@hidden> writes:

> Gerd Hoffmann, le Wed 06 Aug 2008 12:14:25 +0200, a écrit :
>> The rough way to merge would look like this:
>> 
>>   - drop xen_console.[ch]
>>   - drop xenfb.[ch]
>>   - drop xen_machine_pv.c
>> 
>>   - add xen.h
>>   - add xen-machine.c
>>   - add xen-backend.[ch]
>>   - add xen-console.c
>>   - add xen-framebuffer.c
>> 
>>   - wind up stuff in the Makefiles.
>>   - some global renames (domid -> xen_domid for example) as I took care
>>     to prefix global xen variables & functions with xen_.
>>   - probably some small fixups are needed ...
>
> You forgot the _test_ stage.  You are basically asking us to replace our
> well-tested implementation with your implementation, that's quite a
> move.  You are not even providing a patch for us to check that nothing
> has been left behind...

It *is* quite move, becauses it accomplishes a lot: it goes from a
heavily modified fork of an oldish version all the way to merge with
upstream, as far as PV is concerned.

If that's where we want to go, we can of course still argue whether we
should go in leaps or baby steps, and whether Gerd's leap lands in
quite the right spot.  But the distance to conquer remains the same,
and so does the testing challenge.

For what it's worth, I went over significant parts of Gerd's patch
(all the generic stuff + pvfb) with a fine comb, comparing it to what
we have now.  I consider it sound.

[...]