Re: [Qemu-devel] [PATCH] upgrading emulated UART to 16550A

[Samuel Thibault]

Anthony Liguori, le Thu 07 Aug 2008 16:13:10 -0500, a écrit :
> Samuel Thibault wrote:
> >Anthony Liguori, le Thu 07 Aug 2008 13:58:43 -0500, a écrit :
> >  
> >>>@@ -21,6 +21,10 @@
> >>> * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER 
> >>> DEALINGS IN
> >>> * THE SOFTWARE.
> >>> */
> >>>+
> >>>+#include <termios.h>
> >>>+#include <sys/ioctl.h>
> >>> 
> >>>      
> >>This doesn't look Windows friendly.
> >>    
> >
> >How is qemu compiled on windows?  Native with the windows headers?
> >That's quite different then indeed.
> >  
> 
> Yup, via mingw.  But it doesn't seem termios or sys/ioctl are really 
> being used in this file anyway?

Actually I checked the patch. I thought these includes were in vl.c.
These are at least used for TIOCM_*.  I guess those should rather
receive a qemu abstracted name, and be converted to TIOCM_* in vl.c

Samuel