On 8/11/08, Anthony Liguori <address@hidden> wrote:
Avi Kivity wrote:
You lose the switch(nb_args) in monitor_handle_command() so it
comes out
even. You don't need to cast anything -- though you do need to
change all
the callbacks to accept an argument array.
And to either explicitly cast each argument or explicitly parse each
argument. It touches quite a bit of places in the code and makes the
callbacks quite a bit more complicated.
Using a void * is a one line change and works on all modern
systems. Seems
like a winner to me :-)
I vote for this. The other solutions do not improve type safety
(except for union) and they are more complex.