|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH 01/11] Handle terminating signals. |
Date: | Mon, 11 Aug 2008 20:53:02 -0500 |
User-agent: | Thunderbird 2.0.0.16 (X11/20080723) |
Gerd Hoffmann wrote:
Anthony Liguori wrote:Gerd Hoffmann wrote:Unless I'm misreading, none of your patches seem to use this function. What are you adding this mechanism for?+void fatalsig_register_handler(void (*func)(void));The patch using that isn't fully polished yet for submission. Sneak preview is here: http://kraxel.fedorapeople.org/patches/qemu-upstream/0015-xen-domain-builder.patch Adds pv domain builder to qemu, so you can start pv xen guests using qemu only. In that case we'll want to destroy the guest domain when qemu goes down because the xen management stack will not cleanup after us.
I was asking because I thought it may be something like this. An alternative to this signal handler stuff would be to fork() off a process with another end of a pipe. That process could just sit their waiting for eof and when eof was received, it could destroy the domain.
The main advantage of this approach is that it works in every possible circumstance. Even if the qemu process totally borks it's stack or tramples over memory in such a way as to render the signal handling code broken.
Regards, Anthony Liguori
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |