Re: [Qemu-devel] [RFC, PATCH] Host AIO support detection, OpenBSD host support

[Blue Swirl]

On 8/14/08, malc <address@hidden> wrote:
> On Wed, 13 Aug 2008, Blue Swirl wrote:
>
>
> > On 8/12/08, Anthony Liguori <address@hidden> wrote:
> >
> > > Blue Swirl wrote:
> > >
> > >
> > > > Here are two patches, loosely based on patches in OpenBSD ports system
> > > > that enable compiling Qemu. The first patch makes AIO use conditional
> > > > on host AIO support. The second one adjusts various include files etc.
> > > >
> > > > I'd like to commit both of these, is that OK?
> > > >
> > > >
> > > >
> > >
> > >  The first patch is fine but the second patch has some bogus things in
> it.
> > >
> >
> > Thanks for the review. I removed the unneeded parts, made a separate
> > patch for fixing OSS selection, and added a configure option for AIO
> > as requested by Samuel Thibault.
> >
>
>  Thanks for the OSS bits, i have committed slightly modified patch that
>  takes all possible drivers into consideration.

Great, but there is a bug in your commit, *) case seems to be checked
before oss|sdl... case gets into play so the error is still present:

Error: Unknown driver 'oss' selected
Possible drivers are: oss sdl esd