Re: [Qemu-devel] pty/tty functions for BSD too

[Anthony Liguori]

Samuel Thibault wrote:
> Hello,
>
> In Xen, pty/tty functions are enabled for BSD too, shouldn't we enable
> them in upstream qemu too, as patched below?
>   

And you're sure that these functions compile/work on NetBSD/OpenBSD?  If 
so, we can enable them.

Regards,

Anthony Liguori

> Samuel
>
> Index: vl.c
> ===================================================================
> --- vl.c        (révision 5022)
> +++ vl.c        (copie de travail)
> @@ -2466,7 +2466,7 @@
>  }
>  #endif
>  
> -#if defined(__linux__) || defined(__sun__)
> +#if defined(__linux__) || defined(__sun__) || defined(__NetBSD__) || 
> defined(__OpenBSD__)
>  
>  typedef struct {
>      int fd;
> @@ -3816,7 +3816,7 @@
>          return qemu_chr_open_pp(filename);
>      } else
>  #endif
> -#if defined(__linux__) || defined(__sun__)
> +#if defined(__linux__) || defined(__sun__) || defined(__NetBSD__) || 
> defined(__OpenBSD__)
>      if (strstart(filename, "/dev/", NULL)) {
>          return qemu_chr_open_tty(filename);
>      } else
>
>
>