|
From: | Asheesh Laroia |
Subject: | Re: [Qemu-devel] [RESEND][PATCH] APIC: Do not start zero-period timers |
Date: | Mon, 18 Aug 2008 12:29:51 -0700 (PDT) |
User-agent: | Alpine 1.10 (DEB 962 2008-03-14) |
On Mon, 18 Aug 2008, Anthony Liguori wrote:
Jan Kiszka wrote:The APIC timer must not start when the initial count is (still) zero. This caused occasional stalls when booting secondary CPUs of Linux SMP guests.Applied. Thanks.Besides testing, I confirmed that this is what's done in the in-kernel APIC in KVM (which is also used by Xen). It seems really unfortunate to me that there are fixes in the in-kernel APIC that aren't in QEMU (and perhaps vice-versa). I wonder if there's any way to unify the two code bases?
Just a thought - if the code bases have similar textual content, one could start playing games like noticing when the kernel releases have APIC changes in KVM, and then mailing those as [PATCH] automatically to this list by detecting the commit log messages for them from kernel git.
And vice versa, even?Even just a web page that shows the two implementations side by side, highlighting the diff, could probably be useful.
-- Asheesh. -- Experience is what you get when you were expecting something else.
[Prev in Thread] | Current Thread | [Next in Thread] |