Re: [Qemu-devel] [PATCH] ACPI suspend type field is 3 bits long

[Aurelien Jarno]

On Thu, Jun 26, 2008 at 11:12:31AM +0300, Gleb Natapov wrote:
> According to ACPI spec table 4-13 suspend type field should be 3 bits
> long.
> 
> diff --git a/hw/acpi.c b/hw/acpi.c
> index 1f83dc6..8f08a7e 100644
> --- a/hw/acpi.c
> +++ b/hw/acpi.c
> @@ -152,7 +152,7 @@ static void pm_ioport_writew(void *opaque, uint32_t addr, 
> uint32_t val)
>              s->pmcntrl = val & ~(SUS_EN);
>              if (val & SUS_EN) {
>                  /* change suspend type */
> -                sus_typ = (val >> 10) & 3;
> +                sus_typ = (val >> 10) & 7;
>                  switch(sus_typ) {
>                  case 0: /* soft power off */
>                      qemu_system_shutdown_request();

Thanks, applied.

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net