[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [5055] Handle terminating signals (Gerd Hoffmann)
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] Re: [5055] Handle terminating signals (Gerd Hoffmann) |
Date: |
Fri, 22 Aug 2008 13:32:04 +0200 |
User-agent: |
Thunderbird 2.0.0.16 (X11/20080723) |
Hi,
>> } else {
>> + if (shutdown_requested)
>> + break;
>> timeout = 10;
> Could we define the policy that no patch is merged which introduces new
> compiler warnings?
Just double-checked. I don't get a warning for some strange reason.
Was wondered how a warning bypassed my attention.
You probably see "ret can be used uninitialized ...", right?
> --- a/vl.c
> +++ b/vl.c
> @@ -7624,8 +7624,10 @@ static int main_loop(void)
> timeout = 0;
> }
> } else {
> - if (shutdown_requested)
> + if (shutdown_requested) {
> + ret = EXCP_INTERRUPT;
> break;
> + }
Fix looks fine to me.
cheers,
Gerd
--
http://kraxel.fedorapeople.org/xenner/