[Qemu-devel] Re: [5055] Handle terminating signals (Gerd Hoffmann)

[Jan Kiszka]

Gerd Hoffmann wrote:
>   Hi,
> 
>>>          } else {
>>> +            if (shutdown_requested)
>>> +                break;
>>>              timeout = 10;
> 
>> Could we define the policy that no patch is merged which introduces new
>> compiler warnings?
> 
> Just double-checked.  I don't get a warning for some strange reason.
> Was wondered how a warning bypassed my attention.

I like colorgcc for this a lot (either distcc or icecream is said to
support this as well). :)

> 
> You probably see "ret can be used uninitialized ...", right?

Yep. Are you compiling qemu with gcc-3.3 (here: 3.3.3 hammer, x86_64 host)?

> 
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -7624,8 +7624,10 @@ static int main_loop(void)
>>                  timeout = 0;
>>              }
>>          } else {
>> -            if (shutdown_requested)
>> +            if (shutdown_requested) {
>> +                ret = EXCP_INTERRUPT;
>>                  break;
>> +            }
> 
> Fix looks fine to me.

So we don't need to bother about no_shutdown in this path?

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux