|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] Re: [5055] Handle terminating signals (Gerd Hoffmann) |
Date: | Fri, 22 Aug 2008 07:52:45 -0500 |
User-agent: | Thunderbird 2.0.0.16 (X11/20080723) |
Jan Kiszka wrote:
Could we define the policy that no patch is merged which introduces new compiler warnings? Fix below remove the one caused by the hunk above, but it still leaves some doubts for the semi-informed reader because the "if (shutdown_requested)" block under vm_running also checks for no_shutdown. Please confirm that leaving it out here was by intention.
I do check for warnings. The version of GCC I'm using (3.4.6 20060404 (Red Hat 3.4.6-9)) does not complain about these things. We probably should add -Wall to the build and take the time to fix up all of the warnings that occur.
Regards, Anthony Liguori
Jan -------- Always return EXCP_INTERRUPT when leaving main_loop due to shutdown_requested. Signed-off-by: Jan Kiszka <address@hidden> --- vl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: b/vl.c =================================================================== --- a/vl.c +++ b/vl.c @@ -7624,8 +7624,10 @@ static int main_loop(void) timeout = 0; } } else { - if (shutdown_requested) + if (shutdown_requested) { + ret = EXCP_INTERRUPT; break; + } timeout = 10; } #ifdef CONFIG_PROFILER
[Prev in Thread] | Current Thread | [Next in Thread] |