[Qemu-devel] Re: [5055] Handle terminating signals (Gerd Hoffmann)

[Jan Kiszka]

Anthony Liguori wrote:
> Jan Kiszka wrote:
>> Could we define the policy that no patch is merged which introduces new
>> compiler warnings? Fix below remove the one caused by the hunk above,
>> but it still leaves some doubts for the semi-informed reader because the
>> "if (shutdown_requested)" block under vm_running also checks for
>> no_shutdown. Please confirm that leaving it out here was by intention.
>>   
> 
> I do check for warnings.  The version of GCC I'm using (3.4.6 20060404
> (Red Hat 3.4.6-9)) does not complain about these things.  We probably
> should add -Wall to the build and take the time to fix up all of the
> warnings that occur.

Makes /me wonder why 3.4 thinks there is no problem here (while this is
obviously wrong).

Being lazy and SuSE-based (which only provides a 3.3.3 for such legacy
use cases, IIRC), and also remembering vaguely that there used to be
warnings about 3.4 /wrt qemu, I kept 3.3.3.

BTW, do you also check for 64-bit issues? My feeling is that this - at
least - used to be a rare host platform for qemu contributors.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux