Re: [Qemu-devel] [PATCH] Check for gcc3 only if compiling dyngen targets

[Anthony Liguori]

Hervé Poussineau wrote:
> Hi,
>
> If no configured target needs dyngen, gcc3.x is not required. Currently,
> you have to explicitly pass --disable-gcc-check flag to allow compilation.
>
> Attached patch removes gcc check if no selected target needs dyngen.
> I had to move gcc4 detection later in the configure script
>   

This patch breaks gcc3 autodetection in a subtle way.  You more the 
autodetect down much further after $cc is used to compile a bunch of 
test executables.  gcc3 autodetection may change $cc so all of those 
compile tests are now invalid.

I posted a patch a while ago that did basically the same thing but 
didn't suffer from this problem.  Paul Brook basically Nacked it though 
as it's a lot of ugliness for little short term gain.  Let's wait a bit 
longer and hope that the remaining targets get converted to TCG before 
doing a partial switch to gcc4.

Regards,

Anthony Liguori

> Hervé
>