qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Add VMware machine


From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH] Add VMware machine
Date: Sun, 24 Aug 2008 20:24:25 +0300

On 8/24/08, Hervé Poussineau <address@hidden> wrote:
> Hi,
>
>  Attached patch adds a 'vmware' machine type.
>  This one automatically uses VMware display card, and enables VMware mouse.
>  In non VMware machine types (ie 'pc' and 'isapc' types), VMware backdoor
>  and VMware mouse are disabled [1]
>
>  I added an enum with PC types in pc.c . This system can be extended
>  later to add more PC types.
>
>  Please comment.

Please take a look at the hwdef structure in hw/sun4m.c, maybe it
makes the code simpler if instead of checking if the machine type
matches a set, you'd check if the feature is enabled in the the
structure instance.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]