Re: [Qemu-devel] [PATCH 3/6] Add "info uuid" command to monitor.

[Blue Swirl]

On 8/24/08, Gleb Natapov <address@hidden> wrote:
> Signed-off-by: Gleb Natapov <address@hidden>
>  ---
>
>   monitor.c |   13 +++++++++++++
>   1 files changed, 13 insertions(+), 0 deletions(-)
>
>  diff --git a/monitor.c b/monitor.c
>  index e71f49e..1e477bb 100644
>  --- a/monitor.c
>  +++ b/monitor.c
>  @@ -253,6 +253,17 @@ static void do_info_name(void)
>          term_printf("%s\n", qemu_name);
>   }
>
>  +static void do_info_uuid(void)
>  +{
>  +    char uuid_str[37];
>  +    sprintf(uuid_str, UUID_FMT, qemu_uuid[0], qemu_uuid[1], qemu_uuid[2],
>  +            qemu_uuid[3], qemu_uuid[4], qemu_uuid[5], qemu_uuid[6],
>  +            qemu_uuid[7], qemu_uuid[8], qemu_uuid[9], qemu_uuid[10],
>  +            qemu_uuid[11], qemu_uuid[12], qemu_uuid[13], qemu_uuid[14],
>  +            qemu_uuid[15]);
>  +    term_printf("%s\n", uuid_str);

Please use snprintf. Or why not directly term_printf(UUID_FMT "\n",
qemu_uuid[0] etc.?