qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/6] Use libuuid if available.


From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH 4/6] Use libuuid if available.
Date: Sun, 24 Aug 2008 20:50:42 +0300

On 8/24/08, Gleb Natapov <address@hidden> wrote:
>  +# uuid library
>  +if test "$uuid" = "yes" ; then
>  +  `pkg-config uuid 2> /dev/null` || uuid="no"
>  +fi

Please implement the probe like ncurses one.

>  +static int uuid_dont_generate;

Positive logic would be clearer: generate_uuid = 1;

>  +#ifdef CONFIG_UUID
>  +                uuid_dont_generate = 1;

generate_uuid = 0;

>  +    if (!uuid_dont_generate)
>  +        uuid_generate(qemu_uuid);

if (generate_uuid)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]