Re: [Qemu-devel] [patch 1/2] add pci config space struct

[Gerd Hoffmann]

Avi Kivity wrote:
> Gerd Hoffmann wrote:
>>> Shouldn't little-endian types be used here to force the users to use
>>> little-endian accessors?
>>>     
>>
>> Didn't notice qemu has that.  Which header file I should check?  There
>> is nothing in bswap.h ...
> 
> I don't think qemu has them; it should though.

Adding byteordered types is a completely separate issue IMHO.

> I'd define le32 (and friends) as a struct to ensure it is impossible to
> misuse.

Sure, that is the usual way ;)

I expected you suggest to just use something which is present already
though.

cheers,
  Gerd