[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch 2/2] add default pci subsystem id for all device
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [patch 2/2] add default pci subsystem id for all devices. |
Date: |
Wed, 27 Aug 2008 13:10:29 +0100 |
User-agent: |
KMail/1.9.9 |
On Tuesday 26 August 2008, Gerd Hoffmann wrote:
> This sets a default PCI subsystem ID for all emulated PCI devices.
> PCI specs require this, so do it. Individual devices can overwrite
> it of course. The defaults are global variables so they can easily
> be changed (before device creation)
This is just asking for trouble. Having devices set magic global variables
before they create the device is a truly horrible API.
Paul