[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS commun
From: |
Gleb Natapov |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication. |
Date: |
Sun, 31 Aug 2008 17:18:19 +0300 |
With the fix below this patch series works for me.
On Sun, Aug 31, 2008 at 04:39:34PM +0300, Blue Swirl wrote:
> +static uint8_t fw_cfg_read(FWCfgState *s)
> +{
> + int arch = !!(s->cur_entry & FW_CFG_ARCH_LOCAL);
> + FWCfgEntry *e = &s->entries[arch][s->cur_entry & ~FW_CFG_ARCH_LOCAL];
> + uint8_t ret;
> +
> + if (s->cur_entry != FW_CFG_INVALID || !e->data || s->cur_offset >=
> e->len)
This should be "==" ^^^
> + ret = 0;
> + else
> + ret = e->data[s->cur_offset++];
> +
> + FW_CFG_DPRINTF("read %d\n", ret);
> +
> + return ret;
> +}
> +
--
Gleb.
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., (continued)
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/28
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/28
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Gleb Natapov, 2008/08/29
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/29
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/30
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Gleb Natapov, 2008/08/31
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/31
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/31
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Gleb Natapov, 2008/08/31
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/31
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication.,
Gleb Natapov <=
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/31
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Gleb Natapov, 2008/08/31
[Qemu-devel] [PATCH v3 2/6] Add -uuid command line option., Gleb Natapov, 2008/08/28
[Qemu-devel] [PATCH v3 3/6] Add "info uuid" command to monitor., Gleb Natapov, 2008/08/28
[Qemu-devel] [PATCH v3 4/6] Use libuuid if available., Gleb Natapov, 2008/08/28
[Qemu-devel] [PATCH v3 5/6] Add UUID to firmware configuration info., Gleb Natapov, 2008/08/28
[Qemu-devel] [PATCH v3 6/6] Pass cpu speed into SM BIOS., Gleb Natapov, 2008/08/28