qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] More gcc -Wflags


From: Blue Swirl
Subject: [Qemu-devel] More gcc -Wflags
Date: Thu, 4 Sep 2008 22:09:34 +0300

These patches enable gcc warning flags -Wendif-labels, -Wshadow and
-Wpointer-arith. The other patches fix some of these warnings.

For -Wendif-labels there is nothing to fix, all code is clean. I'd
enable this flag.

Enabling -Wshadow produces a lot of useless warnings about variables
named 'index' etc, so I'm not proposing to add that. I might still fix
the warnings for local variables shadowing each other, but maybe it's
not worth the trouble and risk for new bugs.

Fixes for -Wpointer-arith are not too many, except for ARM devices.
Maybe there the use of void * arithmetics is intentional? If Paul
agrees that these should be fixed, I could make a patch that removes
these warnings too. After that, the flag could be enabled.

Attachment: wpointer_arith.diff
Description: plain/text

Attachment: fix_wpointer_arith.diff
Description: plain/text

Attachment: wshadow.diff
Description: plain/text

Attachment: fix_wshadow.diff
Description: plain/text


reply via email to

[Prev in Thread] Current Thread [Next in Thread]