Re: [Qemu-devel] [PATCH 0/3] [x86] Add Core 2 Duo CPU specification v4

[Anthony Liguori]

Alexander Graf wrote:
> Hi,
>
> this set of patches attempts to implement a CPU definition set for
> current Intel CPUs that resembles an original as closely as currently
> possible. Several features a current Intel CPU has are not implemented
> by qemu, but that should not keep us from adding this definition so
> people can add features later on.
>
> As a side effect, I made the sysenter instruction 64-bit aware. This was
> an issue in KVM, that used the 32-bit cpu struct variables to hold
> 64-bit MSR  values sysenter needs. I believe it to be a step in the
> right direction to not fix this only for KVM, but make the functionality
> available to qemu as well.

I'm generally uncomfortable with this series because it starts 
advertising things to guests that are not actually implemented.

How would you feel about splitting out some of the sysenter fixes and 
general cleanups but keeping the vendor identification out of tree?

Regards,

Anthony Liguori

> Version 2 adds save/load. Only the sysenter implementation has changed.
> Version 3 pushes the series from -p2 to -p1
> Version 4 fixes a stupid typo (bels instead of betls)
>
> Alex