Re: [Qemu-devel] [PATCH v2 1/6] Use IO port for qemu<->guest BIOS communication.

[Anthony Liguori]

Gleb Natapov wrote:
> On Wed, Aug 27, 2008 at 08:10:49PM +0300, Blue Swirl wrote:
>   
> > On 8/27/08, Gleb Natapov <address@hidden> wrote:
> >     
> > >  On Tue, Aug 26, 2008 at 07:46:20PM +0300, Blue Swirl wrote:
> > >  > > Is the patch below what you mean? (not tested, but compiles)
> > >  >
> > >  > Yes, but I'd still put the code from the .h file and pc.c to a new .c
> > >  > file, only the keys and function prototypes to .h.
> > >  >
> > >
> > > Okey, here is updated one (compiled only)
> > >       
> > I added some missing pieces like static/const keywords, device
> > save/load and reset, MMIO and Sparc32/64 support. I also renamed some
> > names for consistency.
> >     
> Thanks! I'll rebase my other patches on this and will test it.
>   

I think this is missing save/restore support.  What happens if you do a 
save, move to a different machine, then do a restore, and reboot?  The 
guest will see a different value IIUC.

Also, instead of returning 0 on non-linux systems, why not just return 
some fixed value?  It's no more "wrong" than returning the host clock rate.

Regards,

Anthony Liguori

> --
>                         Gleb.
>
>
>