qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: [Qemu-devel] [PATCH 01/13] Handle terminating signal


From: Anthony Liguori
Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH 01/13] Handle terminating signals.
Date: Sat, 06 Sep 2008 21:41:43 -0500
User-agent: Thunderbird 2.0.0.16 (X11/20080723)

Ian Jackson wrote:
Jamie Lokier writes ("Re: [Xen-devel] Re: [Qemu-devel] [PATCH 01/13] Handle 
terminating signals."):
A quick read of Glibc 2.3.1 source says its AIO code does not change
the signal mask when it creates an AIO handling thread.

Thanks for investigating that.

(This might be a Glibc bug - threads you don't know about shouldn't be
receiving your signals, should they?)

Yes, it's a bug.  (I wonder why my test program didn't expose it.)

That means if it wasn't masked when you issued the first AIO request,
it won't be masked in that thread.

In practice since we use aio this probably means we can't rely on
signal blocking except for signals which qemu keeps blocked `nearly
all' the time.  So pipe-to-self in the signal handler is the way to
go.

In my signalfd patch, we block SIGUSR2 all the time so it shouldn't be affected by this "bug". We use sigwait or signalfd to receive the signal.

Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]