qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] [RESEND] wrap up use of dangerous ctype.h macro


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] [RESEND] wrap up use of dangerous ctype.h macros
Date: Sat, 06 Sep 2008 21:49:07 -0500
User-agent: Thunderbird 2.0.0.16 (X11/20080723)

Ian Jackson wrote:
Anthony Liguori writes ("Re: [Qemu-devel] [PATCH] [RESEND] wrap up use of dangerous 
ctype.h macros"):
Can't we just have qemu_isspace() macros? I find the CTYPE macro quite awkward. I don't think most people are comfortable with that kind of syntax.

I don't have a strong opinion about this.  But of course qemu_isspace
et al would require us to list in qemu-common.h all of the isfoobar
and towombat functions.

At least, the ones we actually use.  I'd definitely prefer this.

Regards,

Anthony Liguori

Ian.







reply via email to

[Prev in Thread] Current Thread [Next in Thread]