[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pcnet: add loopback mode emulation
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH] pcnet: add loopback mode emulation |
Date: |
Mon, 08 Sep 2008 08:18:48 +0200 |
User-agent: |
Thunderbird 2.0.0.16 (Windows/20080708) |
Anthony Liguori wrote:
> Jan Kiszka wrote:
>> This patch enhances the pcnet NIC emulation with better loopback mode
>> support, including CRC generation for looped-back packets in "raw" mode.
>> The patch has practically no impact on the normal RX and TX path.
>>
>> Successfully tested against an ancient proprietary pcnet driver that
>> does a lot of hardware checks on boot-up and now works fine over qemu as
>> well.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>> hw/pcnet.c | 89
>> ++++++++++++++++++++++++++++++++++++++++---------------------
>> 1 file changed, 59 insertions(+), 30 deletions(-)
>>
>> Index: b/hw/pcnet.c
>> ===================================================================
>> --- a/hw/pcnet.c
>> +++ b/hw/pcnet.c
>> @@ -35,6 +35,8 @@
>> *
>> http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR92C990.txt
>>
>> */
>>
>> +#include <netinet/in.h>
>>
>>
>
> That'll break the windows build. It's not immediately clear to me why
> you're including netinet/in.h. Is it for htonl? I think arpa/inet.h is
> where htonl is defined...
>
> At any rate, qemu_socket.h is probably what you want, but I'd like to
> know why you're adding it in the first place.
htonl, and it was fixed in SVN just as you suggested.
Jan
signature.asc
Description: OpenPGP digital signature