Re: [Qemu-devel] [PATCH 1 of 3] [UPDATE] vnc dynamic resolution

[Anthony Liguori]

Stefano Stabellini wrote:
> Anthony Liguori wrote:
>
>   
> > Stefano Stabellini wrote:
> >     
> > >
> > Perhaps the source of my confusion is the use of red_max and red_max1. 
> > Could you try some more descriptive names?  I understand what the code
> > is doing now but it's very easy to confuse the two masks.
> >
> >     
>
> I understand.
> I went with red_max1 because we were already using this "notation" with
> red_shift and red_shift1.
>   

Yeah, I assumed that's why.

> How do you suggest I should call them?
>   

server_red_max and client_red_max seem like the obvious candidates to 
me.  Changing the shift1's would also be a nice fix.

Regards,

Anthony Liguori