qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/1][RESEND] v2: Fix text console size/resize wh


From: andrzej zaborowski
Subject: Re: [Qemu-devel] [PATCH 1/1][RESEND] v2: Fix text console size/resize when using curses
Date: Mon, 15 Sep 2008 18:48:17 +0200

Hi,

2008/9/4 Ryan Harper <address@hidden>:
> v2: drop initial size adjustment, not needed.
>
> Resize events fail to ensure that both the text console and curses display 
> areas
> are the same size; this causes broken output like:

It seems that this was broken by r4812.  Your patch looks correct but
I think it will prevent things like -serial vc:80Cx24C from working as
documented. There's a conflict here: either virtual consoles have
commandline-set fixed size or they adjust to the window size like
before r4812 and don't have parts that don't fit on the screen. The
SDL window is not resizable but the curses window is always resizable.
 I propose to add TEXT_CONSOLE_FIXED_SIZE back, it was removed by
r4812.  I will do this unless there are better ideas.

Another idea would be to set the default console size to 640x400 and
agree to not support terminals < 80x24.

Regards




reply via email to

[Prev in Thread] Current Thread [Next in Thread]