[Qemu-devel] [5286] Fix ARM NEON vdup and vtbl bugs.

[Paul Brook]

Revision: 5286
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5286
Author:   pbrook
Date:     2008-09-22 00:52:42 +0000 (Mon, 22 Sep 2008)

Log Message:
-----------
Fix ARM NEON vdup and vtbl bugs.

Signed-off-by: Paul Brook <address@hidden>

Modified Paths:
--------------
    trunk/target-arm/op_helper.c
    trunk/target-arm/translate.c

Modified: trunk/target-arm/op_helper.c
===================================================================
--- trunk/target-arm/op_helper.c        2008-09-21 23:15:38 UTC (rev 5285)
+++ trunk/target-arm/op_helper.c        2008-09-22 00:52:42 UTC (rev 5286)
@@ -56,7 +56,7 @@
     for (shift = 0; shift < 32; shift += 8) {
         index = (ireg >> shift) & 0xff;
         if (index < maxindex) {
-            tmp = (table[index >> 3] >> (index & 7)) & 0xff;
+            tmp = (table[index >> 3] >> ((index & 7) << 3)) & 0xff;
             val |= tmp << shift;
         } else {
             val |= def & (0xff << shift);

Modified: trunk/target-arm/translate.c
===================================================================
--- trunk/target-arm/translate.c        2008-09-21 23:15:38 UTC (rev 5285)
+++ trunk/target-arm/translate.c        2008-09-22 00:52:42 UTC (rev 5286)
@@ -2807,7 +2807,7 @@
                         tmp2 = new_tmp();
                         tcg_gen_mov_i32(tmp2, tmp);
                         neon_store_reg(rn, 0, tmp2);
-                        neon_store_reg(rn, 0, tmp);
+                        neon_store_reg(rn, 1, tmp);
                     } else {
                         /* VMOV */
                         switch (size) {
@@ -3814,7 +3814,7 @@
                 tmp2 = new_tmp();
                 tcg_gen_mov_i32(tmp2, tmp);
                 neon_store_reg(rd, 0, tmp2);
-                neon_store_reg(rd, 0, tmp);
+                neon_store_reg(rd, 1, tmp);
                 rd += stride;
             }
             stride = (1 << size) * nregs;
@@ -5498,7 +5498,7 @@
                 }
             } else if ((insn & (1 << 10)) == 0) {
                 /* VTBL, VTBX.  */
-                n = (insn >> 5) & 0x18;
+                n = ((insn >> 5) & 0x18) + 8;
                 if (insn & (1 << 6)) {
                     tmp = neon_load_reg(rd, 0);
                 } else {
@@ -5508,6 +5508,7 @@
                 tmp2 = neon_load_reg(rm, 0);
                 gen_helper_neon_tbl(tmp2, tmp2, tmp, tcg_const_i32(rn),
                                     tcg_const_i32(n));
+                dead_tmp(tmp);
                 if (insn & (1 << 6)) {
                     tmp = neon_load_reg(rd, 1);
                 } else {
@@ -5518,7 +5519,8 @@
                 gen_helper_neon_tbl(tmp3, tmp3, tmp, tcg_const_i32(rn),
                                     tcg_const_i32(n));
                 neon_store_reg(rd, 0, tmp2);
-                neon_store_reg(rd, 1, tmp2);
+                neon_store_reg(rd, 1, tmp3);
+                dead_tmp(tmp);
             } else if ((insn & 0x380) == 0) {
                 /* VDUP */
                 if (insn & (1 << 19)) {