qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 2/3] Move aio implementation out of raw block dr


From: Marcelo Tosatti
Subject: [Qemu-devel] Re: [PATCH 2/3] Move aio implementation out of raw block driver
Date: Wed, 24 Sep 2008 19:31:09 -0300
User-agent: Mutt/1.5.18 (2008-05-17)

On Mon, Sep 22, 2008 at 09:45:29PM -0500, Anthony Liguori wrote:
>> +#endif
>> +
>> +typedef struct RawAIOCB {
>> +    BlockDriverAIOCB common;
>> +    struct aiocb posix_aiocb;
>> +    struct RawAIOCB *next;
>> +    int ret;
>> +} RawAIOCB;
>>   
>
> The whole small-object allocator for AIOCBs seems a bit of a premature  
> optimization to me.  It makes this whole thing terribly awkward.   
> Marcelo had a patch at one point to switch the small object allocate to  
> just malloc/free.  Marcelo: any reason you didn't follow up with that 
> patch?

You mean the free object caching? Yeah can't see much point in it.

Will look for it.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]