qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH] Add USB sys file-system support (v6)


From: Anthony Liguori
Subject: Re: [Qemu-devel] Re: [PATCH] Add USB sys file-system support (v6)
Date: Fri, 26 Sep 2008 09:37:58 -0500
User-agent: Thunderbird 2.0.0.16 (X11/20080723)

Robert Riebisch wrote:
Anthony Liguori wrote:

Thanks for trying to help, but it's *still* whitespace damaged.  This
may seem like a minor nit but not taking the time to try and make code
match up with the rest of the source tree doesn't suggest that much time
has been taking to make the code fit in architecturally or to think
about any sort of wider interactions.  I also like to give an author the
chance to fix something because it helps encourage people to do the
right thing the first time around.

Isn't there an official GNU indent guide for the QEMU sources?

Perhaps, but I use the following in emacs:

(c-add-style "qemu"
       '("stroustrup"
               (indent-tabs-mode . nil)
               (c-basic-offset   . 4)
               (tab-width . 8)
       )
       nil)

Perhaps someone can post the appropriate vim-fu too.

Regards,

Anthony Liguori
Robert Riebisch





reply via email to

[Prev in Thread] Current Thread [Next in Thread]