Re: [Qemu-devel] Makefile question

[Robert Riebisch]

Anthony Liguori wrote:

> > +
> > +%.o: %.rc
> > +    windres -I. -DORIGINAL_FILENAME=\"$(QEMU_PROG)\" -c -o $< $@
> 
> This needs to be ${cross_prefix}windres

MinGW's windres doesn't have a "-c" option.

> > +if test "$mingw32" = "yes" ; then
> > +echo "#define QEMU_FILEVERSION $(tr . , < $source_path/VERSION),0" >>
> > $config_h
> > +echo "#define QEMU_PRODUCTVERSION $(tr . , < $source_path/VERSION),0"
> > >> $config_h
> > +fi
> >
> 
> You could just use QEMU_VERSION in the .rc file

Instead of QEMU_FILEVERSION and QEMU_PRODUCTVERSION?
No, because FILEVERSION numbers must be in format "a, b, c, d".

> I think it's a good idea to include a default .rc file for the QEMU
> Windows build.  If you update the patch, I'd be happy to apply it.

I'll apply it adjusted to my QEMU 0.9.1 sources and see if it's fine.

Robert Riebisch
-- 
BTTR Software
http://www.bttr-software.de/