Re: [Qemu-devel] [PATCH] ppc32 guests: fix computation of XER.{CA, OV} in addme, subfme, mullwo

[Aurelien Jarno]

On Sun, May 11, 2008 at 02:04:47AM +0200, Julian Seward wrote:
> 
> For ppc32 guests, computation of XER.CA and XER.OV in some obscure
> cases is incorrect.  At least, it doesn't produce the same results
> as a real MPC7447, and doesn't appear to be in accordance with the
> instruction set documentation.
> 
> The attached patch fixes it:
> 
> * addme{o}{.}, subfme{o}{.}: compute XER.CA correctly
> 
> * mullwo{.}: sign extend arguments before doing 64-bit
>   multiply, so as to make the XER.OV computation correct
> 

I fixed both problems by applying a mix of your patch and of the patch
from Jocelyn Mayer.

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net