Re: [Qemu-devel] [patch 2/2] machine struct - specify max_cpus at the per machine level

[Jes Sorensen]

>>>>> "andrzej" == andrzej zaborowski <address@hidden> writes:

andrzej> 2008/10/6 Jes Sorensen <address@hidden>:
>> --- qemu.orig/hw/an5206.c +++ qemu/hw/an5206.c @@ -92,4 +92,5 @@
>> QEMUMachine an5206_machine = { .desc = "Arnewsh 5206", .init =
>> an5206_init, .ram_require = 512, + .max_cpus = 1, };

andrzej> No machine has 0 cpus so there's no point specifying = 1 in
andrzej> every machine instead of making it the default.  The other
andrzej> fields were thought so that they don't have to be specified
andrzej> except for non-default values.

Well making 0 mean 1 is even worse, and adding a 1 in those isn't
bad. Some of the options obviously cannot be left empty and it doesn't
hurt to require this one.

Cheers,
Jes