qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Fix IDE DIAGNOSE for packet devices


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] Fix IDE DIAGNOSE for packet devices
Date: Thu, 09 Oct 2008 09:19:54 -0500
User-agent: Thunderbird 2.0.0.17 (X11/20080925)

Vincent Sanders wrote:
The DIAGNOSE command in the qemu IDE implementation has an error when
use dfor packet devices.
The status register value is dependant on the drive being a packet
device or not, this patch corrects the returned status.

From the ATA/PI specification (V6 draft):

"If the device implements the PACKET command feature set, the device
SHALL clear bits 6,5,4,3,2 and 0 in the Status register to zero."

A selection of physical devices have been checked and do conform to
the specifications behaviour.

Signed-off-by: Vincent Sanders <address@hidden>

Applied.  Thanks.

Regards,

Anthony Liguori




reply via email to

[Prev in Thread] Current Thread [Next in Thread]