Re: [Qemu-devel] [PATCH] Davicom DM9000 emulation

[Paul Brook]

On Monday 13 October 2008, Daniel Silverstone wrote:
> On Mon, 2008-10-13 at 15:01 +0100, Daniel Silverstone wrote:
> > Attached is the fixed patch with these changes.
>
> I have to apologise -- that patch lacked some semi-colons.
>
> Also, it appears that some devices don't have the headers required for
> target_phys_addr_t included before they include devices.h so I had to
> use an #ifdef around the dm9000_init declaration. If this isn't right
> then I need to know what the right thing to include in such drivers is.
> It seems a bit unfortunate to force other drivers to include headers
> they were otherwise managing without.

Using target_phys_addr_t is a lie. Your device only implements 32 bits of 
address space.

Paul