qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] 2/5: open() can also return EPERM for O_RDWR on

From: Aurelien Jarno
Subject: Re: [Qemu-devel] [PATCH] 2/5: open() can also return EPERM for O_RDWR on a readonly device
Date: Mon, 13 Oct 2008 23:08:44 +0200
User-agent: Mutt/1.5.18 (2008-05-17) 
Applied, thanks.

On Wed, Oct 01, 2008 at 08:36:09PM +0200, Juergen Lock wrote:
> ..at least on FreeBSD.  (I think the case where this happened was a cdrom.)
> 
> Index: qemu/block.c
> @@ -381,7 +381,7 @@
>      else
>          open_flags = flags & ~(BDRV_O_FILE | BDRV_O_SNAPSHOT);
>      ret = drv->bdrv_open(bs, filename, open_flags);
> -    if (ret == -EACCES && !(flags & BDRV_O_FILE)) {
> +    if ((ret == -EACCES || ret == -EPERM) && !(flags & BDRV_O_FILE)) {
>          ret = drv->bdrv_open(bs, filename, BDRV_O_RDONLY);
>          bs->read_only = 1;
>      }
> 
> Signed-off-by: Juergen Lock <address@hidden>
> 
> 
> 

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net
reply via email to
[Prev in Thread] Current Thread [Next in Thread]