[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] gdbstub: remove unused local variable
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] gdbstub: remove unused local variable |
Date: |
Tue, 14 Oct 2008 17:50:31 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Tue, Oct 14, 2008 at 05:57:11AM -0700, Nathan Froyd wrote:
> On Tue, Oct 14, 2008 at 11:12:05AM +0200, Jan Kiszka wrote:
> > --- a/gdbstub.c
> > +++ b/gdbstub.c
> > @@ -604,8 +604,6 @@ static int cpu_gdb_write_register(CPUSta
> > #else
> > else if (n < 64) {
> > /* f0-f31 */
> > - uint32_t fpr;
> > -
> > env->fpr[n] = ldfl_p(mem_buf);
> > return 4;
> > } else if (n < 80) {
>
> And if somebody wanted to fix that to return 8 instead of 4, that'd be
> great too. :)
>
What's the rational behind that? AFAIK f0-f31 "registers" are 32-bit
"registers", even on SPARC64.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' address@hidden | address@hidden
`- people.debian.org/~aurel32 | www.aurel32.net