[Qemu-devel] Re: [PATCH 02/13] Refactor and enhance break/watchpoint API

[Jan Kiszka]

Glauber Costa wrote:
>>  /* Add a watchpoint.  */
>> -int cpu_watchpoint_insert(CPUState *env, target_ulong addr, int type)
>> +int cpu_watchpoint_insert(CPUState *env, target_ulong addr, target_ulong 
>> len,
>> +                          int flags, CPUWatchpoint **watchpoint)
> 
> Any particular reason you're not simply returning the address of the 
> watchpoint?
> Although I must admit it's a matter of personal taste.

Then I would have to express potential errors as pointer values. I think
I didn't find a precedence for this in QEMU, so I went for the above
interface.

Jan

signature.asc
Description: OpenPGP digital signature