Re: [Qemu-devel] [PATCH][RFC] Optimize ld[bwlq]_phys and st[bwlq]_phys

[Blue Swirl]

On 10/14/08, Anthony Liguori <address@hidden> wrote:
> This patch optimizes the ld and st functions that operate on physical 
> addresses.
>  Right now, a number of them default to cpu_phys_memory_{read,write} which is
>  very slow.  As long as the operations are aligned, it is safe to just lookup
>  the page and directly read/write the data via ld_p or st_p.
>
>  This patch introduces a common function since all of these functions are
>  roughly the same.  I've tested x86 and sparc with Linux and Windows guests.
>
>  I'm pretty confident that this new code is functionally equivalent but I 
> wanted
>  to have someone else confirm this.

Why there are special cases for lduw and stw?

I'd add 'inline' to the common functions, otherwise looks OK.