qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Implement "info chardev" command.


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] Implement "info chardev" command.
Date: Tue, 21 Oct 2008 10:03:27 -0500
User-agent: Thunderbird 2.0.0.17 (X11/20080925)

Gerd Hoffmann wrote:
  Hi,

This patch makes qemu keep track of the character devices in use and
implements a "info chardev" monitor command to print a list.

Is it better to enumerate all chardevs or to provide info functions for each type of chardev (i.e. 'info serial', 'info parallel'). I don't have a strong feeling either way.

The only thing I'd suggest about this patch is that if you're going to print pty:/dev/pty/3, then you should also support that syntax for specifying a pty. Otherwise, there's a lack of symmetry.

Regards,

Anthony Liguori

please apply,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]