Re: [Qemu-devel] [PATCH] [resubmit] Allocate translation buffer before guest RAM, in case guest RAM is too large on 64 bit hosts

[Laurent Desnogues]

On Thu, Oct 23, 2008 at 12:10 AM, Juergen Lock <address@hidden> wrote:
>
>  Further explanation as requested: cpu_exec_init_all() below allocates
> code_gen_buffer which needs to be in the lower 4G (actually 2G I guess)
> because it uses 32 bit branch offsets.  Allocate this first so that the
> guest RAM allocation can't get in the way i.e. block the lower vm when
> doing something like -m 4096 on systems that allocate from low addresses
> by default.
>
>  I hope this is more clear now? :)

What about including a shorter version of that explanation as a comment
in your patch ? :)


Laurent