[Qemu-devel] Re: [PATCH 17/32] build list of available accelerators

[Avi Kivity]

> > >  +typedef struct QEMUCont {
> > > +    QEMUAccel *acc;
> > > +    int active;
> > > +    struct QEMUCont *next;
> > > +} QEMUCont;
> > >   
> > >       
> > The name is unclear.  But you could fold the structure into QEMUAccel, no?
> >     
> Yes, it was folded in my first version. It is separated just to allow external
> accelerators to register themselves without messing with the accelerator list, 
> which
> would be internal. But I'm probably just being overzealous.
>
>   

You could still have a registration function.  The accelerator itself 
would not need to touch the members.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.