Re: [Qemu-devel] QEMU on Solaris 10 (was: [PATCH 01/32] use anonymous memory for kqemu.)

[Blue Swirl]

On 10/25/08, Andreas Färber <address@hidden> wrote:
>
>  Am 25.10.2008 um 12:17 schrieb Andreas Färber:
>
>
> >
> > Am 24.10.2008 um 21:59 schrieb Ben Taylor:
> >
> >
> > > the big problem I see is that the addition of c99 features
> > > borks a qemu compile on Solaris, specfically around stdbool.h.
> > > Turning on -std=c99 or -std=gnuc99 creates more problems because
> > > gcc-3.4.3 provided by solaris doesn't accept the anonymous unions
> > > that are prevalent around the new code, specifically nbd and vnc.
> > >
> >
> > I just gave it a try on S10 5/08 amd64, using the gcc 3.4.3 from Sun and
> --disable-gcc-check
> >
> > * configure complains about an illegal -q for grep.
> > It's used in a check for GNU ld. Could we use other options there or let
> grep be overridable to ggrep?
> >
> > Since I am building on amd64, it also complained that libSDL is not amd64,
> so I use: --disable-sdl --disable-gfx-check
> >
> > I can confirm the build failure due to stdbool.h. I therefore add:
> --extra-cflags=-std=gnu99
> >
> > sparc-softmmu then compiles fine.
> >
>
>  Small addition here: in hw/bt-hci.c in bt_submit_hci I spotted an implicit
> declaration of function `strndup'

I get the same warning on OpenBSD, and there is also
/src/qemu/hw/bt-hci.c:1818: warning: assignment makes pointer from
integer without a cast

Maybe there should be a pstrdup function in cutils.c.