[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: Preliminary patch to implement ehci
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: Preliminary patch to implement ehci |
Date: |
Mon, 27 Oct 2008 16:26:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Glauber Costa wrote:
> On Mon, Oct 27, 2008 at 12:00 PM, Anthony Liguori <address@hidden> wrote:
>> Mark Burkley wrote:
>>> Hi folks,
>>>
>>> Just checking, did anyone get a chance to look at this?
>>>
>>> Any suggestions for next steps? Should I post a patch against trunk?
>>>
>> Submitting the patch against 0.9.1 is a non-starter. 0.9.1 is at least a
>> year old and the USB code has been majorly refactored. If you want people
>> to review it, it has to be against trunk.
>>
>> Also make sure that you include a [PATCH] in your subject. Otherwise, it's
>> easily missed on the list.
> The chances of anyone reviewing a patch that big is also very small.
> So please, split it in minor, self-contained patches so it make it
> easier for reviewers.
As this patch mostly adds a new implementation, I'm not sure if that
request matches here.
But I have two further remarks:
- Ensure that your patch is not line-wrapped (maybe you have to switch
your mail client, dunno if Outlook is "fixable")
- Adopt your patch to the coding style you find in other qemu files
(check at least two so that you don't accidentally pick a bad example
;) )
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
- [Qemu-devel] Preliminary patch to implement ehci, Mark Burkley, 2008/10/17
- RE: [Qemu-devel] Preliminary patch to implement ehci, Mark Burkley, 2008/10/27
- Re: [Qemu-devel] Preliminary patch to implement ehci, Anthony Liguori, 2008/10/27
- RE: [Qemu-devel] Preliminary patch to implement ehci, Mark Burkley, 2008/10/27
- RE: [Qemu-devel] Preliminary patch to implement ehci, Mark Burkley, 2008/10/30
- Re: [Qemu-devel] Preliminary patch to implement ehci, Anthony Liguori, 2008/10/30
- Re: [Qemu-devel] Preliminary patch to implement ehci, Max Krasnyansky, 2008/10/31