qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/4] sockets: switch vnc to new code, support vn


From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH 3/4] sockets: switch vnc to new code, support vnc port auto-allocation.
Date: Tue, 28 Oct 2008 19:25:04 +0200

On 10/28/08, Gerd Hoffmann <address@hidden> wrote:
> This patch switches the vnc code ofer to the new socket helper
>  functions.
>  -    if (strcmp(display, "none") == 0)
>  -       return 0;
>  -
>      if (!(vs->display = strdup(display)))
>         return -1;
>  +    if (strcmp(display, "none") == 0)
>  +       return 0;

Why this change? It looks like it will leak memory if display is "none".




reply via email to

[Prev in Thread] Current Thread [Next in Thread]